Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

South Africa-class 1 AashiqAbrahams JS-core1 week1#90

Closed
aashiqabrahams123 wants to merge 12 commits into
CodeYourFuture:masterfrom
aashiqabrahams123:master
Closed

South Africa-class 1 AashiqAbrahams JS-core1 week1#90
aashiqabrahams123 wants to merge 12 commits into
CodeYourFuture:masterfrom
aashiqabrahams123:master

Conversation

@aashiqabrahams123
Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Aashiq Abrahams
  • Your City: South Africa
  • Your Slack Name: Aashiq Abrahams

Homework Details

  • Module: JavaScript
  • Week:1

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@aashiqabrahams123 aashiqabrahams123 changed the title South Africa class 1 AashiqAbrahams JS-core1 week1 South Africa-class 1 AashiqAbrahams JS-core1 week1 Mar 18, 2021
@chandredewet
Copy link
Copy Markdown

chandredewet commented Mar 29, 2021

Hi Aashiq,,

Well done on completing JS-1- Week 1. And getting through it! Trust the following weeks you will catch up and be able to get even more from class interaction and fellow trainees. Just a few observations from my side...

Exercises:
L| Just to confirm the exercise on CYF side was not clear and in fact erroneous, well done on still trying. I will advise the syllabus team to correct it as they gave two exercises but one file to work on.

Mandatory:
1-syntax-errors.js:

  • If you compare expected: 'Hello, my name is Sonjide and I am 27 years old' to what your function returned 'Hello, my name is Sonjideand I am 27years old' there is a small error to fix with the spaces. Correct this until you see the test pass.
  • Similarly "return 'The total is ${total}'; " failed because this will only work with backticks, which I see you use in the rest of the homework, so if you can just edit this to pass.

in 3. you added the various variables and strings together without using the concat function. While this will work, try and also learn how to use the concat function for multiple inputs. It would still begin with:
return firstWord.concat( with all the rest of the input in here);

Lastly in 4, inside your function, you make price = calculateSalesTax(price); this is not incorrect but it may be better to rather have had a new variable e.g. priceWithTax, for readability when others read your code. Just a thought here to consider.

@aashiqabrahams123
Copy link
Copy Markdown
Author

@chandredewet, Thank your for your feedback, I've managed to fix my errors, just a heads up that when I did the commit name is wrong as it should be "Mandatory-Fixed Errors"..

@github-actions
Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label May 13, 2021
@github-actions github-actions Bot closed this May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants