South Africa-class 1 AashiqAbrahams JS-core1 week1#90
South Africa-class 1 AashiqAbrahams JS-core1 week1#90aashiqabrahams123 wants to merge 12 commits into
Conversation
|
Hi Aashiq,, Well done on completing JS-1- Week 1. And getting through it! Trust the following weeks you will catch up and be able to get even more from class interaction and fellow trainees. Just a few observations from my side... Exercises: Mandatory:
in 3. you added the various variables and strings together without using the concat function. While this will work, try and also learn how to use the concat function for multiple inputs. It would still begin with: Lastly in 4, inside your function, you make price = calculateSalesTax(price); this is not incorrect but it may be better to rather have had a new variable e.g. priceWithTax, for readability when others read your code. Just a thought here to consider. |
|
@chandredewet, Thank your for your feedback, I've managed to fix my errors, just a heads up that when I did the commit name is wrong as it should be "Mandatory-Fixed Errors".. |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?